[pull] master from Konloch:master #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…alog Add xapk extension in SUPPORTED_FILE_EXTENSIONS
More of a pre-caution - if parsing fails we should still attempt to display the decompiled code. I've encountered a few errors and manually added them in, but I'm worried I missed one. To fix that I figure we just catch everything that isn't an IO Error. IO-Errors are probably user related (lack of space, insufficient permissions, etc) - So these errors we should forward to the user, the rest we can silence for developer eyes
- We could now also add the popup menu on the tab itself if we want to instead of just the button.
Middle Click on Tabs
A few fixes for parsing
This may introduce some visual startup delay - will need to profile with JS engines on the classpath
Due to the way the global variable is being created - this may introduce some visual startup delay - will need to profile with JS engines on the classpath
To make temporary plugins work with the BCV.getCurrentlyOpenedClassNode() API, we have to store the last active class viewer in memory There is probably a better way of doing this, but the only code using these APIs are user plugins, so it shouldn't impact the rest of the program if we have a resource mismatch
[Parser] Add examples of what each visitor visits among other things
A small update to parsing
- Added 0.1s wait between opening class and registering "Go-To" caret event, hopefully fixes text area not scrolling to caret. - Added/Re-added ability to open a field declaration in its owner class if the scope was a parameter or variable.
- Added 'field1.field2' where field2 is parsed also - Added '::method' calls
…e class can be decompiled correctly, and we can parse it.
Inner classes and a few additions to the parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )