Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up type converters #14

Merged
merged 1 commit into from
Oct 2, 2015

Conversation

sliekens
Copy link
Collaborator

  • Change converter naming convention.
    Previous naming convention: 'ConverterForXyz'
    New naming convention: 'XyzConverter'
  • Change data contract naming convention.
    Previous naming convention: 'XyzDataContract'
    New naming convention: 'XyzDTO'
  • Move types into matching files
  • Move initialization code to te bootstrapper.
    The bootstrapper is now reponsible for initializing converters.
  • Convert internal classes to public sealed.
    This change is necessary to be able to initialize converters
    from outside their containing assembly.
  • Improve argument exception messages
    When 'ArgumentException' (or a derivation) is thrown, the
    message should say what is expected instead of what isn't.
  • Replace boilerplate converter code with T4 templates
    Where possible, T4 text templates and reflection are used
    to automatically generate type converters for well-known
    entities.
  • Add integration tests

Resolves: #7
See also: #5

 - Change converter naming convention.
     Previous naming convention: 'ConverterForXyz'
     New naming convention: 'XyzConverter'

 - Change data contract naming convention.
     Previous naming convention: 'XyzDataContract'
     New naming convention: 'XyzDTO'

 - Move types into matching files

 - Move initialization code to te bootstrapper.
     The bootstrapper is now reponsible for initializing converters.

 - Convert internal classes to public sealed.
     This change is necessary to be able to initialize converters
     from outside their containing assembly.

 - Improve argument exception messages
     When 'ArgumentException' (or a derivation) is thrown, the
     message should say what is expected instead of what isn't.

 - Replace boilerplate converter code with T4 templates
     Where possible, T4 text templates and reflection are used
     to automatically generate type converters for well-known
     entities.

 - Add integration tests

Resolves: Ruhrpottpatriot#7
See also: Ruhrpottpatriot#5
@Ruhrpottpatriot Ruhrpottpatriot merged commit 247aa44 into Ruhrpottpatriot:master Oct 2, 2015
@sliekens sliekens deleted the di-framework branch October 4, 2015 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants