Add Edge support #40
Open
Add Edge support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look into it. My biggest issue at the moment however is disk space on my Windows partition. 🙄 |
|
Right, one other caveat: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8748330/ Super annoying. Not actually a problem. But super annoying. |
|
To be fair on the devs, edge is still a baby by browser standards. Hopefully it matures quickly. |
|
True that. It seems to render and run pretty smoothly (hence the "I wonder if I can port this" given that I'm trying it out). |
|
Per reddit comment, I'm not opposed to this, but I cannot be the maintainer myself. I will leave this here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for edge.
No, I have no idea if it's built right for the store. I've been running it locally and it seems to work pretty well. Similarly no, I have absolutely no desire to publish or maintain this on MS's store for public consumption. I just figured that if it exists I'd PR it up to the mainline and leave build support for it. You'll note
build/edge.ziphas not been added to the main build call.The changes themselves are actually pretty simple.
manifest.jsonfor edge. (Note, in Edge we have to userun_at: "document_end"or elsedocument.headisnull)/addon/vendor). As far as I can tell they're provided unlicensed so we're in the clear there.console.log.bindnot being legal in IEThere is a known issue where apparently every time we call
console.logit fails and throws some unknown error with a long error code. Fuck if I know why that happens but error logging is not something we get to have right now.Anyway, there it is. Figure anyone who wants it and is enterprising enough to build BPM can have it.