Update Firefox extension to WebExtension.

[Spazturtle]

Tomorrow legacy extensions are going to be disabled by default in Firefox Nightly 57 and in a month in Beta and in a month after that in Stable.

https://mail.mozilla.org/pipermail/dev-addons/2017-August/003059.html

[MairusuPawa]

Any news on this?

[Shugabuga]

So far no. I might have to suck it up and port it in a couple days before users start noticing that BPM is broken.

I probably will do a shit job, but 🤷‍♂️.

[Shugabuga]

Update: TypeError: chrome.extension.sendMessage is not a function

This is going to be harder than it should be. However, I have a hutch changing the namespace might do.

On the bright side, I think I fixed the options page.

[Rothera]

I think I'm going to owe you something nice if you pull this off.

[Shugabuga]

I think I pulled it off, and it was due to chrome.extension becoming chrome.runtime.

Just changing a few lines made it port nearly flawlessly (see below for why), on top of changing the manifest (which could be easily dictated in the Makefile.

For instance, this line (cr-background.js)...

chrome.browser.onMessage.addListener(function(message, sender, sendResponse) {

...had to be changed to...
This line (cr-background.js)...

chrome.runtime.onMessage.addListener(function(message, sender, sendResponse) {

Everything in the below tests work in both Chrome Canary and Firefox Nightly:

Tested:

• Emote browser
  • Emote Insertion
  • Help Menus
  • Resizing/Moving
  • Escape-To-Close
  • Prevent Dragging Off Screen
• Animotes
• Collapse Emotes
• Effects
• ExtraCSS effects
• Preferences
• RES Support
  • Live Preview
  • Night Mode
  • Show In Front-Page Preview
• Everything From This Thread works
• [](/spoiler)
• Text Effects ([Hello](/red!-center) works as intended)

[Andoryuu]

Our saviour Shugabuga.
I didn't try to actually recompile it from the source with the commit. Just downloaded the old chrome version, converted to xpi and mass replaced the runtime. But it still works and I can see ponies once again.

Thank you.

[Shugabuga]

Glad I was able to help out!

Also, if anyone needs to use this build immediately (i.e. the latest version of BPM no longer runs in Firefox), I have compiled and listed it here.

[bb010g]

I wrote an alternative patch over at #49, which I think would be nicer long-term.