"Skip Child Zelda" Doesn't Propagate Triforce Pieces on Song from Impa

[rehashedsalt]

Encountered in the 3-man seed 913318:

• Generation Date 2021-10-18 1:54:23 AM UTC
• Seed AUSYSKYQWQ
• Settings String CJASFCH8KAB87RAA2LBAJPTJMX2TTL62AYDLHSK2RAAAAJCAASGAAUWAA

Dunno what build/commit the site's using, but I'm sure it could be inferred based on generation time.

Behavior

The setting "Skip Child Zelda" is turned on and player 2 starts with a PotT in their pocket courtesy of the ZL check:

      "Song from Impa [W2]":                                     {"item": "Triforce Piece", "player": 2}

However, this PotT did not appear in worlds 1/3. We had to manually declare victory once world 2 finished the game.

Expected Behavior

The PotT spawns in everyone's pockets at the start of the game. I haven't peeked at the code, but I'm assuming propagation logic is already there and is simply choking on the fact that P2 "owns" this item.

[Roman971]

Thanks for the bug report.

There indeed seems to be an issue with starting Triforce Pieces not being handling properly in multiworld. There is also an issue about it on the upstream repo (OoTRandomizer#1425), and we should hopefully have a fix for it soon.

[fenhl]

This was fixed in OoTRandomizer#1523, just needs to be merged into Dev-R.