Add LightningCAD Generator #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malachirwin
requested review from
johncalvinyoung,
kylesmile,
seanpk and
Jeremy-Walton
kylesmile
reviewed
Apr 26, 2024
| @@ -0,0 +1,123 @@ | |||
| export default { | |||
There was a problem hiding this comment.
Probably better to just use the ESLint config provided by the generic (non-L.CAD) generator. There might be changes from projects that could be good to bring in to our base config.
| say 'Adding jasmine' | ||
| run "yarn add --dev jasmine@^5.1.0" | ||
|
|
||
| run 'npm pkg set scripts.test_shared="NODE_ENV=test NODE_PATH="./node_modules:./app/javascript:$NODE_PATH" jasmine --config=jasmine.json"' |
There was a problem hiding this comment.
I don't think NODE_PATH works with ESM, but we can add a custom import hook to replicate the behavior.
| say 'Updating esbuild loader in the config' | ||
|
|
||
| insert_into_file 'webpack.config.js', " include: /app\\/javascript|@rolemodel\\/lightning-cad/,\n", before: " loader: 'esbuild-loader'," | ||
| gsub_file 'webpack.config.js', 'es2021', 'esnext' |
There was a problem hiding this comment.
We probably don't want to change the output target.
| def update_esbuild_loader | ||
| say 'Updating esbuild loader in the config' | ||
|
|
||
| insert_into_file 'webpack.config.js', " include: /app\\/javascript|@rolemodel\\/lightning-cad/,\n", before: " loader: 'esbuild-loader'," |
There was a problem hiding this comment.
I don't think this is needed, since the base config doesn't seem to exclude node_modules from being processed with esbuild-loader.
Malachirwin
force-pushed
the
lightning-cad-generator
branch
from
a32aac9 to
62a7dd6
Compare
Malachirwin
force-pushed
the
lightning-cad-generator
branch
from
a3e66e0 to
1900cf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The former system for spinning up a L.CAD app doesn't work in the slightest and was not worth repairing. This pulls some pieces from that but is implemented on
rolemodel_railsWhat Changed
What the generator adds
.npmrc.eslintrc.jsjavascript/config/initializers/smartJSON.jsjavascript/components/LocalIconFactory.jsxjavascript/components/MaterialIcon.jsxcontrollers/editor_controller.rbviews/editor/editor.html.slimjavascript/components/App.jsxjasmine.jsonspec/javascript/shared/TestSetup.jsspec/javascript/shared/testSpec.jsLater
This doesn't fully support the setup for persisted project setup which is most of the use case we need to setup. This only replaces the old generators that don't work. After we have the replacement we can look at some of those other bells and whistles.