Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed HTML dialog element blocks background clicks because of display: block. #236

Open
reedrolemodel opened this issue Oct 18, 2024 · 0 comments
Open

Closed HTML dialog element blocks background clicks because of display: block. #236

reedrolemodel opened this issue Oct 18, 2024 · 0 comments

Comments

@reedrolemodel
Copy link
Member

reedrolemodel commented Oct 18, 2024 •
edited
Loading

Should this be removed?

optics/src/components/modal.scss

Line 118 in ea7a897

display: block;

It blocks elements behind it even when closed. I believe the dialog.showModal() API handles visibility.

image

In the above screenshot, the "Add Mileage" button can't be clicked because the dialog element is over it. When opened it looks like this:
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reedrolemodel