Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring, documentation, etc... #4

Open
4 tasks
yotam180 opened this issue Mar 11, 2018 · 2 comments
Open
4 tasks

Code refactoring, documentation, etc... #4

yotam180 opened this issue Mar 11, 2018 · 2 comments
Assignees
@shaiTheKimhi @nofearOnline

Comments

@yotam180
Copy link
Member

yotam180 commented Mar 11, 2018 •
edited by CatchTheWindows
Loading

Some problems to address:

  • lab2/lab2/Field.py – please document the circular_field function properly (including the expected parameters & types, the meaning of the function and the return type).
  • lab2/lab2/Field.py– Operator spacing (e.g. 1/math.cos(angle)**2)
  • lab2/lab2/index.py – Operator spacing (e.g. ...ta=myfil...)
  • lab2/lab2/index.py – No inline comments please. (#return_code,headers,code of the page(here it is html))

Thank you.
@nofearOnline
Copy link
Collaborator

how do u want the comments to look like?

@yotam180
Copy link
Member Author

As specified in PEP 257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaiTheKimhi shaiTheKimhi

@nofearOnline nofearOnline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yotam180 @shaiTheKimhi @nofearOnline