ENH: Environment object from EnvironmentAnalysis

[ArthurJWH]

This method allows the user to create a Environment object from the EnvironmentAnalysis object

Pull request type

• Code changes (bugfix, features)

Checklist

• Tests for the changes have been added (if needed)
• Docs have been reviewed and added / updated
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest tests -m slow --runslow) have passed locally
• CHANGELOG.md has been updated (if relevant)

Current behavior

Issue #657

New behavior

The env method have been added, which creates a Environment object from the data retrieved from the EnvironmentAnalysis class

Breaking change

• Yes
• No

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (4df0b38) to head (56dadb4).
Report is 19 commits behind head on develop.

Files with missing lines	Patch %	Lines
rocketpy/environment/environment_analysis.py	25.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #813      +/-   ##
===========================================
+ Coverage    79.11%   79.82%   +0.70%     
===========================================
  Files           96       98       +2     
  Lines        11575    11962     +387     
===========================================
+ Hits          9158     9549     +391     
+ Misses        2417     2413       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Gui-FernandesBR]

Two points:

1. The method would benefit a lot from a docstring!
2. The name could be a lot more clearer. A few options should be: to_rocketpy_environment, to_environment_object, get_environment_object, instantiate_environment_object. I'm giving some very different options because I'd like you to propose what you think would be clearer to the final user. Anything apart from "env" should already be fine.

[Gui-FernandesBR]

Please mention [in docs] you're using the average profiles.

[ArthurJWH]

Yes. I'm just waiting for a response on how to deal with the inversion function before proceeding, because currently there is a problem with the pressure profile. But after the code works, I'll be making the code cleaner (tests, documentation, the name...)

[Gui-FernandesBR]

is there anything you need from me?

[Gui-FernandesBR]

This is really nice. So simple and effective.
Great work @ArthurJWH ! I think you're getting the hang of it...

Some extra points I'd like to add before :

• could you please update the CHANGELOG?
• How familiar are you with unit tests?
• There's an open issue in this repo that may be connected with your PR. Could you please link the PR using the "development" section on the "conversation" section here on GitHub?

[ArthurJWH]

This is really nice. So simple and effective. Great work @ArthurJWH ! I think you're getting the hang of it...

Some extra points I'd like to add before :

• could you please update the CHANGELOG?
• How familiar are you with unit tests?
• There's an open issue in this repo that may be connected with your PR. Could you please link the PR using the "development" section on the "conversation" section here on GitHub?

I will update the CHANGELOG soon.
For tests, I just had one test asserting that the method would return an Environment object. But there is this one problem with the pressure profile that, if it is not "bijective", then the invert function would just give an error.
The issue #657 should be already linked, if there is other related issue, let me know.