Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add file linting for size and name #63

Merged
merged 37 commits into from
Aug 29, 2024

Conversation

ghostrider-05
Copy link
Member

@ghostrider-05 ghostrider-05 commented Aug 5, 2024

Please describe the changes this PR makes and why it should be merged:

NOTE: updates the contributing guidelines to be stricter

  • adds npm run lint-files:name to validate the new guidelines for naming files
  • adds npm run lint-files:size to validate files to be < 1MB
  • adds an action to label PRs on file changes
  • adds a step in the build process to validate frontmatter (keys)

Code changes:

  • updates eslint to v9
  • pins theme-rlmm to github releases
  • updates theme-rlmm to v0.7.0 and enables the steam maps title switcher on the home page
  • refactors configuration code

Guide changes:

  • typos fixed and some headers updated
  • updates all images to have meaningful file names and alt texts
  • adds the page-inline-images class to display all images inline on a page
  • add GitHub link to guide contributers
  • adds back the Mipmaps and LOD page in the sidebar
  • rename The owl page to Building a map
  • adds features to testing and building page
    image
    image

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation changes
  • Build-related changes
  • Other, please describe:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Code changes have been tested locally, or there are no code changes
  • I have followed the steps to contribute and followed the guidelines
  • If my contribution contains a workflow, I've performed said workflow directly before making the change request and no steps are missing.

Other information

@ghostrider-05 ghostrider-05 mentioned this pull request Aug 8, 2024
14 tasks
@ghostrider-05 ghostrider-05 marked this pull request as ready for review August 29, 2024 12:07
@ghostrider-05 ghostrider-05 merged commit 5f06ef0 into RocketLeagueMapmaking:master Aug 29, 2024
5 checks passed
@ghostrider-05 ghostrider-05 deleted the ci/file-lint branch August 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant