Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'onClick' is missing #38

Closed
muuvmuuv opened this issue Apr 15, 2019 · 2 comments
Closed

Property 'onClick' is missing #38

muuvmuuv opened this issue Apr 15, 2019 · 2 comments
Labels

Comments

@muuvmuuv
Copy link

Why do I need to handle onClick by myself? In the docs it says "by default" so I guess this should be optional:

Argument of type '{ title: string; }' is not assignable to parameter of type 'WebpackBuildNotifierConfig'.
  Property 'onClick' is missing in type '{ title: string; }' but required in type 'WebpackBuildNotifierConfig'.

see: index.d.ts#L96

@RoccoC RoccoC added the bug label Apr 16, 2019
@RoccoC
Copy link
Owner

RoccoC commented Apr 16, 2019

You are right, onClick should be made optional.

RoccoC added a commit that referenced this issue Apr 16, 2019
@RoccoC
Copy link
Owner

RoccoC commented Apr 16, 2019

Fixed in 0.1.32.

@RoccoC RoccoC closed this as completed Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants