Fix BufferBackend
soundness issue and add StringInterner::resolve_unchecked
#68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49.
This fix vastly deteriorates the performance of
BufferBackend::resolve
which is why I addedStringInterner::resolve_unchecked
for users to mitigate the performance issue on their side if they are sure to always use valid symbols.Even with the regressed performance for
resolve
theBufferBackend
is the choice for especially memory constrained environments.Benchmarks: