Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuperfluidCorrelator and StringCorrelator #227
SuperfluidCorrelator and StringCorrelator #227
Changes from 21 commits
b07894d
09ecb19
6936e53
b0f55dc
24424e4
f678274
a41cb7c
b1196e3
dee2a97
ee64158
250addb
79cdf9c
4228197
a4dfaed
bb61bf8
713077f
fc6c6c7
b868f97
83564ea
332d430
6f0c473
582fa0e
29af492
224b5c1
ad2abc2
b05b669
9577c41
a4a8e80
c0c8eaa
e4f1076
7cf8ebb
080dd54
6e3e49f
ca4da60
9ee513a
36ab44c
b42b037
a29deeb
2a3afca
77c8022
9260ed3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a definition for the mean particle number, i.e.
\\bar{n}=N/M
, where ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been altered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks a bit untidy to initialise
result
with anInt64
and then addComplexFloat64
s to it. Will this result in a type instability?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be more efficient to avoid complex numbers altogether for integer filling factor. Probably the best way to do this is to branch at the beginning of the function on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is worth checking whether this will produce type-stable code. It should.