Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t55_chk #2744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

t55_chk #2744

wants to merge 1 commit into from

Conversation

jareckib
Copy link
Contributor

@jareckib jareckib commented Feb 4, 2025

corrected options -y or -d

corrected options -y or -d

Signed-off-by: Jarek Barwinski <116510448+jareckib@users.noreply.github.com>
Copy link

github-actions bot commented Feb 4, 2025

You are welcome to add an entry to the CHANGELOG.md as well

@iceman1001
Copy link
Collaborator

don't change the simple help text colors.
I know that it doesn't match the native commands help text, but if you start changing one lua script help, you better be prepared to consequently change all of them. Might not be a bad idea but I don't think you want to do that now.

@iceman1001
Copy link
Collaborator

I also just noticed your file names doesn't follow the pattern either.

t55_chk -> lf_t55xx_chk etc.

@jareckib
Copy link
Contributor Author

jareckib commented Feb 4, 2025

Script t55_chk.lua only creates a dictionary-T5577date.dic. Later the dictionary is used in the command: "lf t55xx chk -f my_dictionary_pwds -> loads a default keys dictionary file". The same dictionary was created for the option "y" or "d". Now I have fixed it.

@iceman1001
Copy link
Collaborator

As mentioned you have changed the colors in the help text section. Don't.

@jareckib
Copy link
Contributor Author

jareckib commented Feb 4, 2025

I made a script because I encountered a case where someone set the date as a password... If it's not needed, delete it.

@jareckib
Copy link
Contributor Author

jareckib commented Feb 4, 2025

I made a script for Paxon to automatically create a backup from Paxon to Paxon with a single click. I did this because my building, Spectrum Building in Dagenham, burned down, and I lost all my tools. Thank you for your understanding of the mistakes i make.

@iceman1001
Copy link
Collaborator

I understand that you made a script and you had your reasons.
I am commenting the changes needed to be done in order to have the same code style in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants