Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create overloads for API init functions to specify custom hosts. #400

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Feb 21, 2025

Deprecates rc_api_set_host and rc_api_set_image_host. Custom hosts are now passed to _hosted alternatives for each API _init function.

Passing NULL to the _hosted functions will use the default hosts. The non-_hosted versions pass the custom hosts assigned by calling rc_api_set_host and rc_api_set_image_host. Once those functions are fully removed, the non-_hosted versions will just pass NULL and the default hosts will be used.

The existing rc_client_set_host function can be used to specify a custom host for use by a single rc_client instance (it was previously a wrapper for calling the above deprecated functions). It shouldn't be necessary to specify an image host, as #393 and #395 expose full URLs to images that should be used instead of trying to build a URL.

@Jamiras Jamiras added this to the 12.0.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant