Merge pull request #112 from simleo/update_remote_entity

Updates to handling of remote data entities
ResearchObject · Mar 9, 2022 · 3dba4a1 · 3dba4a1
2 parents 6fe2b48 + 87aa7c8
commit 3dba4a1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/rocrate/model/file_or_dir.py b/rocrate/model/file_or_dir.py
@@ -43,7 +43,6 @@ def __init__(self, crate, source=None, dest_path=None, fetch_remote=False,
                 raise ValueError("dest_path must be provided if source is not a path or URI")
             if is_url(str(source)):
                 identifier = os.path.basename(source) if fetch_remote else source
-                properties.update({'url': source})
             else:
                 identifier = os.path.basename(source)
         super().__init__(crate, identifier, properties)
diff --git a/rocrate/rocrate.py b/rocrate/rocrate.py
@@ -349,7 +349,7 @@ def add_file(
             source=None,
             dest_path=None,
             fetch_remote=False,
-            validate_url=True,
+            validate_url=False,
             properties=None
     ):
         return self.add(File(
@@ -366,7 +366,7 @@ def add_dataset(
             source=None,
             dest_path=None,
             fetch_remote=False,
-            validate_url=True,
+            validate_url=False,
             properties=None
     ):
         return self.add(Dataset(
@@ -490,7 +490,7 @@ def write_zip(self, out_path):
         return archive
 
     def add_workflow(
-            self, source=None, dest_path=None, fetch_remote=False, validate_url=True, properties=None,
+            self, source=None, dest_path=None, fetch_remote=False, validate_url=False, properties=None,
             main=False, lang="cwl", lang_version=None, gen_cwl=False, cls=ComputationalWorkflow
     ):
         workflow = self.add(cls(
@@ -557,7 +557,7 @@ def add_test_instance(self, suite, url, resource="", service="jenkins", identifi
         return instance
 
     def add_test_definition(
-            self, suite, source=None, dest_path=None, fetch_remote=False, validate_url=True, properties=None,
+            self, suite, source=None, dest_path=None, fetch_remote=False, validate_url=False, properties=None,
             engine="planemo", engine_version=None
     ):
         if engine_version is None: