From ec3e74aa3973f2a676dd8c18e651c660af5b051b Mon Sep 17 00:00:00 2001
From: Hunt Feng <spacecurvature@gmail.com>
Date: Thu, 11 May 2023 02:19:05 -0600
Subject: [PATCH] Small fixes (#38)

* better performance for large table search

* render standard annots properly

* bump `pdf.js` version for better text selection

* remove appdata on uninstall (nsis)

* fixed recursive update problem in tableview

* Update quasar.config.js

* update workflow
---
 quasar.config.js                           |  2 ++
 src/components/library/ActionBar.vue       |  1 -
 src/components/library/TableProjectRow.vue |  4 ---
 src/components/library/TableView.vue       | 32 +++++++++++++++-------
 4 files changed, 24 insertions(+), 15 deletions(-)

diff --git a/quasar.config.js b/quasar.config.js
index 4a9f705..fc82f7d 100644
--- a/quasar.config.js
+++ b/quasar.config.js
@@ -210,6 +210,8 @@ module.exports = configure(function (/* ctx */) {
         },
         win: {
           target: "nsis",
+        },
+        nsis: {
           deleteAppDataOnUninstall: true,
         },
         mac: {
diff --git a/src/components/library/ActionBar.vue b/src/components/library/ActionBar.vue
index ea42b74..a7f72e8 100644
--- a/src/components/library/ActionBar.vue
+++ b/src/components/library/ActionBar.vue
@@ -131,7 +131,6 @@ const searchText = computed({
     return props.searchString;
   },
   set: debounce((text: string) => {
-    // searchStart(text);
     emit("update:searchString", text);
   }, 500),
 });
diff --git a/src/components/library/TableProjectRow.vue b/src/components/library/TableProjectRow.vue
index 544e871..7acdfc0 100644
--- a/src/components/library/TableProjectRow.vue
+++ b/src/components/library/TableProjectRow.vue
@@ -71,8 +71,4 @@ function authorString(authors: Author[]) {
   }
   return names.join(", ");
 }
-
-defineExpose({
-  authorString,
-});
 </script>
diff --git a/src/components/library/TableView.vue b/src/components/library/TableView.vue
index 57f4979..c4dcb4a 100644
--- a/src/components/library/TableView.vue
+++ b/src/components/library/TableView.vue
@@ -46,7 +46,6 @@
         @click="clickProject(props.row, props.rowIndex)"
         @dblclick="dblclickProject(props.row)"
         @contextmenu="toggleContextMenu(props.row, props.rowIndex)"
-        ref="projectRow"
       ></TableProjectRow>
 
       <!-- Expanded Rows -->
@@ -88,7 +87,7 @@
 <script setup lang="ts">
 // types
 import { computed, PropType, ref } from "vue";
-import { Project, Note } from "src/backend/database";
+import { Project, Note, Author } from "src/backend/database";
 import { QTable, QTableColumn } from "quasar";
 // components
 import TableItemRow from "./TableItemRow.vue";
@@ -113,7 +112,6 @@ const emit = defineEmits([
   "update:selectedProject",
 ]);
 
-const projectRow = ref<typeof TableProjectRow | null>(null);
 const isClickingPDF = ref(false);
 const showExpansion = ref(false);
 const expansionText = ref<string[]>([]);
@@ -138,6 +136,22 @@ const headers = computed(() => {
   ] as QTableColumn[];
 });
 
+/**
+ * Convert array of author objects to string
+ * @param authors
+ */
+function authorString(authors: Author[] | undefined) {
+  if (!!!authors?.length) return "";
+
+  let names = [];
+  for (let author of authors) {
+    if (!!!author) continue;
+    if (!!author.literal) names.push(author.literal);
+    else names.push(`${author.given} ${author.family}`);
+  }
+  return names.join(", ");
+}
+
 /**
  * Select a row in the table
  * @param row
@@ -228,13 +242,11 @@ function searchProject(
     }
 
     // search authors
-    if (projectRow.value) {
-      let authors = projectRow.value.authorString(row.author);
-      if (authors.search(re) != -1) {
-        text = authors.replace(re, `<span class="bg-primary">${terms}</span>`);
-        expansionText.value.push(`Authors: ${text}`);
-        return true;
-      }
+    let authors = authorString(row.author);
+    if (authors.search(re) != -1) {
+      text = authors.replace(re, `<span class="bg-primary">${terms}</span>`);
+      expansionText.value.push(`Authors: ${text}`);
+      return true;
     }
 
     // search notes