Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About graph_pair_sim function #1

Open
zzh-ecnu opened this issue Dec 3, 2020 · 1 comment
Open

About graph_pair_sim function #1

zzh-ecnu opened this issue Dec 3, 2020 · 1 comment

Comments

@zzh-ecnu
Copy link

zzh-ecnu commented Dec 3, 2020

Hello~An excellent work!

When reading your code, i find that the implement of function "graph_pair_sim" is different from loss.py and match_fn.py

Code in match_fn.py

dis_loc = (loc_dis_mat * weight_mat).mean()

Code in loss.py

dis_loc = (loc_dis_mat * weight_mat).sum()

I think cause goal of script is different, so when matching it is mean(), and when calculating loss it is sum(), all right?

@RenMin1991
Copy link
Owner

Yes.

We find that the distances between structures of feature graphs are more important during training than matching.
Hence, mean() decreases the weight of distances between structures of feature graphs comparing to sum().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants