Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and test default_literal annotation for enum #347

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

jwillemsen
Copy link
Member

No description provided.

    * tests/idl4/default/client.cpp:
    * tests/idl4/default/test.idl:
    * ridlbe/c++11/config/cxx_type.rb:
    * ridlbe/c++11/visitors/attribute.rb:
    * ridlbe/c++11/visitors/enum.rb:
    * ridlbe/c++11/visitors/struct.rb:
    * ridlbe/c++11/visitors/union.rb:
    * ridlbe/c++11/config/cxx_type.rb:
    * ridlbe/c++11/visitors/enum.rb:
@jwillemsen jwillemsen changed the title Implement and test default_literal annotations for enum Implement and test default_literal annotation for enum Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (84973e5) 59.77% compared to head (04054c9) 59.77%.

Files Patch % Lines
tests/idl4/default/client.cpp 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   59.77%   59.77%   -0.01%     
==========================================
  Files         588      588              
  Lines       47973    47978       +5     
  Branches     4227     4228       +1     
==========================================
+ Hits        28678    28679       +1     
- Misses      16179    16181       +2     
- Partials     3116     3118       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwillemsen jwillemsen merged commit 80bdd14 into RemedyIT:master Jan 22, 2024
13 of 17 checks passed
@jwillemsen jwillemsen deleted the jwi-defaultliteral branch January 22, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant