fix: 🐛 fixed default GitHub installationId value to ensure it uses Ma…

…gneto config value if unset locally
Rely-io · Oct 8, 2024 · c4efda0 · c4efda0
1 parent 3801ca1
commit c4efda0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/galaxy/core/main.py b/galaxy/core/main.py
@@ -59,7 +59,7 @@ async def main(
         if config_entity_properties is not None:
             for key, value in config_entity_properties.items():
                 # Only set the property if it doesn't already exist
-                if config.integration.properties.get(key, None) is None:
+                if not config.integration.properties.get(key):
                     config.integration.properties[key] = value
 
         logger.debug("Config entity properties: %r", config.integration.properties)

diff --git a/galaxy/integrations/github/config.yaml b/galaxy/integrations/github/config.yaml
@@ -20,6 +20,6 @@ integration:
   properties:
     appId: "{{ env('RELY_INTEGRATION_GITHUB_APP_ID') }}"
     appPrivateKey: "{{ env('RELY_INTEGRATION_GITHUB_APP_PRIVATE_KEY') }}"
-    installationId: "{{ env('RELY_INTEGRATION_GITHUB_INSTALLATION_ID') }}"
+    installationId: "{{ env('RELY_INTEGRATION_GITHUB_INSTALLATION_ID') | default('', true) }}"
     url: "{{ env('RELY_INTEGRATION_GITHUB_URL') | default('https://api.github.com', true)  }}"
     daysOfHistory: "{{ env('DAYS_OF_HISTORY') | default(30, true) | int }}"