-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default theme to dark scheme from minimal-theme #918
Conversation
I feel like we need to figure out a way to have a red that doesn't communicate error to users if we're gonna change it. |
I don't believe most users are thinking in such psychological terms, the vast majority of users just want something visually appealing. The number of users that have directly requested we switch to the minimal-theme cited above is staggering. so its pretty clear the users want a dark theme. The accent color is open to interpretation, in the current state the color has been pulled from the Redot Logo |
I personally agree with this. 2 reasons: makes errors harder to parse out from the other gui, makes me think errors are happening when seeing red text in the corner of my eyes while deep into writing code. Not too biggy cause it can be changed easy enough though I guess. Just my 2 cents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be squashed.
fa67a26
to
703de35
Compare
703de35
to
f4dcfd9
Compare
Is this good to go then? |
I feel like this theming should've included the |
Color scheme change
We want to change the color scheme to something more subtle the red has long received a lot of hate.
Initially we wanted to switch to the godot-minimal-theme but that turned out more complicated than not as it has a 700 line GDScript file that changes a lot of nuances like spacing and margin.
So we decided we could just use the color values from it for now. Feel free to review my values but i belive they are correct.