Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default theme to dark scheme from minimal-theme #918

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

decryptedchaos
Copy link
Member

Color scheme change

We want to change the color scheme to something more subtle the red has long received a lot of hate.

Initially we wanted to switch to the godot-minimal-theme but that turned out more complicated than not as it has a 700 line GDScript file that changes a lot of nuances like spacing and margin.

So we decided we could just use the color values from it for now. Feel free to review my values but i belive they are correct.

@decryptedchaos
Copy link
Member Author

decryptedchaos commented Jan 8, 2025

I actually may change the accent color here not sure, by default minimal-theme uses a blue but we could make it more redot themed with a nice orange

Thoughts?

DONE

image

@Spartan322
Copy link
Member

I feel like we need to figure out a way to have a red that doesn't communicate error to users if we're gonna change it.

@decryptedchaos
Copy link
Member Author

decryptedchaos commented Jan 8, 2025

I feel like we need to figure out a way to have a red that doesn't communicate error to users if we're gonna change it.

I don't believe most users are thinking in such psychological terms, the vast majority of users just want something visually appealing.

The number of users that have directly requested we switch to the minimal-theme cited above is staggering. so its pretty clear the users want a dark theme.

The accent color is open to interpretation, in the current state the color has been pulled from the Redot Logo

@RudyFisher7
Copy link

RudyFisher7 commented Jan 12, 2025

I feel like we need to figure out a way to have a red that doesn't communicate error to users if we're gonna change it.

I personally agree with this. 2 reasons: makes errors harder to parse out from the other gui, makes me think errors are happening when seeing red text in the corner of my eyes while deep into writing code. Not too biggy cause it can be changed easy enough though I guess. Just my 2 cents.

@decryptedchaos
Copy link
Member Author

This has been updated to use an off-white accent color.

This should remedy the red problem.
image

Copy link
Member

@Spartan322 Spartan322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be squashed.

@decryptedchaos
Copy link
Member Author

This needs to be squashed.

Please explain why when this can be done from the github web interface
image

@decryptedchaos decryptedchaos force-pushed the master branch 2 times, most recently from fa67a26 to 703de35 Compare January 13, 2025 20:09
@tindrew
Copy link
Collaborator

tindrew commented Jan 17, 2025

Is this good to go then?

@Spartan322 Spartan322 dismissed their stale review January 17, 2025 20:58

It has been squashed

@tindrew tindrew merged commit d217498 into Redot-Engine:master Jan 18, 2025
20 checks passed
@Spartan322
Copy link
Member

I feel like this theming should've included the config.default_contrast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants