fix: remove the MustGatherContext and InsightsOperatorContext #4330
+49
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4330 +/- ##
==========================================
- Coverage 77.06% 77.05% -0.01%
==========================================
Files 736 736
Lines 41366 41360 -6
Branches 8789 8787 -2
==========================================
- Hits 31877 31869 -8
- Misses 8429 8432 +3
+ Partials 1060 1059 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoySnow
approved these changes
Jan 9, 2025
JoySnow
approved these changes
Jan 10, 2025
|
test me |
2 similar comments
|
test me |
|
test me |
JoySnow
approved these changes
Jan 10, 2025
These two contexts are actually used by CCX rules and redefined in CCX Core too. They are not used in case of non-CCX scenario. Leaving them here would cause archive context identification error, see RHINENG-15103. After this the CCX Core will be the only entry for analyzing must-gather and insights operator archive. Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
|
test me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two contexts are actually used by CCX rules and redefined
in CCX Core too. They are not used in case of non-CCX scenario.
Leaving them here would cause archive context identification
error, see RHINENG-15103
And deprecate all relevant example scripts, e.g.
insighst.ocpandinsights.ocpshell. From now on, the CCX Core will be the onlyentry to analyze must gather and insights operator archives.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here