Do not perform any RBAC calls on openshift bundle (#952)

RedHatInsights · Sep 8, 2020 · 1029aea · 1029aea
1 parent eaef592
commit 1029aea
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/config/setupTests.js b/config/setupTests.js
@@ -38,6 +38,7 @@ global.window.insights = {
                 }
             }))
         },
-        getUserPermissions: () => Promise.resolve([])
+        getUserPermissions: () => Promise.resolve([]),
+        getBundle: () => ''
     }
 };
diff --git a/src/js/App/RootApp.js b/src/js/App/RootApp.js
@@ -63,7 +63,7 @@ RootApp.propTypes = {
     activeLocation: PropTypes.string,
     pageAction: PropTypes.string,
     pageObjectId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
-    globalFilterHidden: PropTypes.boolean
+    globalFilterHidden: PropTypes.bool
 };
 
 function stateToProps({ chrome: { activeApp, activeLocation, appId, pageAction, pageObjectId, globalFilterHidden } }) {

diff --git a/src/js/rbac/fetchPermissions.js b/src/js/rbac/fetchPermissions.js
@@ -6,6 +6,9 @@ const log = logger('fetchPermissions.js');
 const perPage = 25;
 
 export const fetchPermissions = (userToken, app = '') => {
+    if (insights.chrome.getBundle() === 'openshift') {
+        return Promise.resolve([]);
+    }
     const rbacApi = createRbacAPI(userToken);
     return rbacApi.getPrincipalAccess(app, undefined, perPage).then(({ data, meta }) => {
         if (meta.count > perPage) {

diff --git a/src/js/rbac/fetchPermissions.test.js b/src/js/rbac/fetchPermissions.test.js
@@ -20,3 +20,11 @@ it('should send the data as array', async () => {
     expect.assertions(1);
     return data.then(permissions => expect(permissions).toEqual(mockedRbac.data));
 });
+
+it('should not call any rbac', async () => {
+    const previousGetBundle = global.insights.chrome.getBundle;
+    global.window.insights.chrome.getBundle = () => 'openshift';
+    const data = await fetchPermissions('uSeRtOkEn');
+    expect(data).not.toEqual(mockedRbac.data);
+    global.window.insights.chrome.getBundle = previousGetBundle;
+});