Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psk name in openapi manifests for private endpoint #126

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Jan 9, 2024

What?

Related to SWATCH-1969.
I wanted to use the internal openapi spec from here and when testing the generated client using the export service locally which I ran using the instructions from the README, it failed because the expected psk was not provided "x-rh-exports-psk".

Why?

This is failing because the openapi spec defines "x-rh-export-psk" (note the missing s character) instead of "x-rh-exports-psk". After amending this, the test passes.

How?

Testing

I tested these changes using the instructions from the linked PR: RedHatInsights/rhsm-subscriptions#2932

Anything Else?

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48077b1) 45.08% compared to head (6692e01) 45.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files          18       18           
  Lines        1313     1313           
=======================================
  Hits          592      592           
  Misses        680      680           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you!

@tahmidefaz tahmidefaz merged commit 47e9a95 into RedHatInsights:main Mar 18, 2024
8 checks passed
@Sgitario Sgitario deleted the fix_psk_internal branch March 18, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants