MQ2Events doesn't "CleanItemtags"

[Redbot]

In GitLab by @jessebevil on Dec 2, 2020, 19:54

Issue template

- [] What - MQ2Events doesn't "CleanItemTags", so it won't correctly process events like trigger=You begin casting #1#

trigger=You begin casting #1#
command=/bc You begin casting ${EventArg1}

- [] When - Every time. 

Expected the issue is that OnIncomingChat doesn't "CleanItemTags" as seen in VOID CheckChatForEvent(PCHAR szMsg) line 721 in MQ2DataVars.cpp, which causes it to fail to output the name of the spell you begin casting. This will apply for all new outputs that include spells as links for MQ2Events.

Expect that a resolution would be to modify OnIncomingChat to CleanItemTags prior to pEventsEvent->Feed(szLine);

PLUGIN_API DWORD OnIncomingChat(PCHAR Line, DWORD Color)
{
	if (gbInZone && pEventsEvent)
	{
		CHAR szLine[MAX_STRING] = { 0 };
		strcpy_s(szLine, Line);
		if (DEBUGGING)
			WriteChatf("MQ2Events::OnIncomingChat: Feed '%s'", Line);
		pEventsEvent->Feed(szLine);
	}
	return 0;
}

wondering if this is intentional, or just happens to have been overlooked.

[Redbot]

moved from redguides/VeryVanilla#91