Skip to content

Commit

Permalink
5.8.2 Release
Browse files Browse the repository at this point in the history
  • Loading branch information
RealRaven2000 committed Oct 21, 2021
1 parent 699d978 commit cebc97b
Show file tree
Hide file tree
Showing 10 changed files with 102 additions and 201 deletions.
2 changes: 1 addition & 1 deletion build.bat
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ pwsh -Command "(gc -en UTF8NoBOM manifest.json) -replace 'pre%oldRev%', 'pre%qui
echo %quickFoldersRev% > revision.txt
move QuickFolders*.xpi "..\..\..\Release\_Test Versions\5.8\"
pwsh -Command "Start-Sleep -m 150"
rename QuickFoldersWeb.zip QuickFolders-mx-5.8.1pre%quickFoldersRev%.xpi
rename QuickFoldersWeb.zip QuickFolders-mx-5.8.2pre%quickFoldersRev%.xpi
84 changes: 84 additions & 0 deletions chrome/content/qf-scrollmenus.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@

/* function originally contained in scrollMenus.xul */
(function(){
function repeatOnDragover (evt) {
var now = evt.timeStamp || (new Date()).getTime(), timeWarp = (now < tsLastRepeat);
if (timeWarp || now >= (tsLastRepeat + REPEAT_DELAY_MS)) {
tsLastRepeat = now;
if (!timeWarp) { fnRepeat(); }
}
};

var REPEAT_DELAY_MS = 50,
REPEAT_RE = /arrowscrollbox$/i,
tsLastRepeat,
fnRepeat;
var BookmarksMenuDNDObserver = QuickFolders.popupDragObserver;
// prevent the bookmarks menu from closing when a drag is held over the autorepeatbuttons
// and menuseparators (bug 349932 and maybe bug 194319/bug 240709)
if (BookmarksMenuDNDObserver) {
BookmarksMenuDNDObserver.getObserverForNode_SMOD = BookmarksMenuDNDObserver.getObserverForNode;
BookmarksMenuDNDObserver.onDragCloseTarget_SMOD = BookmarksMenuDNDObserver.onDragCloseTarget;

BookmarksMenuDNDObserver.getObserverForNode = function (aNode) {
var observer;
try {
observer = BookmarksMenuDNDObserver.getObserverForNode_SMOD(aNode);
} catch (ex) {}
if (!observer && aNode && aNode.id == "bookmarks-menu") {
observer = this.getObserverForNode(aNode.getElementsByTagName("menupopup")[0]);
}
return observer;
};
BookmarksMenuDNDObserver.onDragCloseTarget = function () {
var currentObserver = this.getObserverForNode(this.mCurrentDragOverTarget);
// close all the menus not hovered by the mouse
for (var i=0; i < this.mObservers.length; i++) {
if (currentObserver != this.mObservers[i]) {
this.onDragCloseMenu(this.mObservers[i]);
if (this.mObservers[i].parentNode.id == "bookmarks-menu")
this.mObservers[i].hidePopup();
}
else {
this.onDragCloseMenu(this.mCurrentDragOverTarget.id == "bookmarks-menu"
? this.mCurrentDragOverTarget.getElementsByTagName("menupopup")[0]
: this.mCurrentDragOverTarget.parentNode
);
}
}
};
}

// activate autorepeatbuttons on dragover (bug 194319)
document.addEventListener("dragenter", function (evt) {
function removeRepeat (evt) {
el.removeEventListener("dragover", repeatOnDragover, true);
el.removeEventListener("dragend", removeRepeat, false);
}
var el = evt.originalTarget, hierarchyLimit = 3;
while (el &&
(el.nodeName!="toolbarbutton" ||
el.id!="scrollbutton-down" && el.id!="scrollbutton-up")) { // scrollbutton-down // !REPEAT_RE.test(el.nodeName)
el = (--hierarchyLimit && el.parentNode);
}
if (el) {
tsLastRepeat = (evt.timeStamp || (new Date()).getTime()) - REPEAT_DELAY_MS;
fnRepeat = function(){
switch(el.id) {
case "scrollbutton-down":
el.parentNode.host.scrollByIndex(1,true);
break;
case "scrollbutton-up":
el.parentNode.host.scrollByIndex(-1,true);
break;
}
};

el.addEventListener("dragover", repeatOnDragover, true);
el.addEventListener("dragend", removeRepeat, false);
repeatOnDragover({timeStamp: evt.timeStamp});

}
}, true);

})();
10 changes: 8 additions & 2 deletions chrome/content/quickfolders.js
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ END LICENSE BLOCK */
## When quickFilters activates its assistant, all icons on left to the tabs will be white
## Added max version (Thunderbird 91.*) as mandated by new policies on ATN.
5.8 QuickFolders Pro - WIP
5.8.1 QuickFolders Pro - 18/10/2021
## [issue 191] Support large icon in QuickFolders toolbar buttons
## [issue 203] When quickFilters activates its assistant, all icons on left to the tabs will be white
## [issue 209] With some themes, tabs in Options Dialog become illegible in Thunderbird 91
Expand All @@ -210,6 +210,12 @@ END LICENSE BLOCK */
## [issue 204] Thunderbird 91: Background of toolbar doesn't support some themes when set to transparent
WORK IN PROGRESS / KNOWN:
## [issue 208] Upgrade from TB 78 to 91.1.2 sometimes leads to invalid / "orphaned" tabs
5.8.2 QuickFolders Pro - WIP
## [issue 5] Long folders menu scroll issues in Thunderbird 68 + 78
## [issue 77] Folder list menu under tabs does not scroll
## [issue 105] list of subfolders not scrolled down
## [issue 67] Subfolder menu does not scroll when dragging email and list of folders is longer than fits on screen
-=-----------------=- PLANNED
## [issue 103] Feature Request: Support copying folders
Expand Down Expand Up @@ -723,7 +729,7 @@ var QuickFolders = {
let type = ev.type || "",
id = ev.target ? (ev.target.id || "") : "no target",
txt = ev ? (type + " " + id) : "";
console.log("toolbarDragObserver:DnD " + txt) ;
console.log("toolbarDragObserver:DnD " + txt, ev) ;
},

canHandleMultipleItems: false,
Expand Down
1 change: 1 addition & 0 deletions chrome/content/scripts/qf-messenger.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Services.scriptloader.loadSubScript("chrome://quickfolders/content/quickfolders-
Services.scriptloader.loadSubScript("chrome://quickfolders/content/quickfolders-folder-category.js", window, "UTF-8");
Services.scriptloader.loadSubScript("chrome://quickfolders/content/qf-styles.js", window, "UTF-8");
Services.scriptloader.loadSubScript("chrome://quickfolders/content/quickfolders-listener.js", window, "UTF-8");
Services.scriptloader.loadSubScript("chrome://quickfolders/content/qf-scrollmenus.js", window, "UTF-8");

var mylisteners = {};

Expand Down
29 changes: 0 additions & 29 deletions chrome/content/scrollPatch/contents.rdf

This file was deleted.

80 changes: 0 additions & 80 deletions chrome/content/scrollPatch/scrollMenus.xul

This file was deleted.

82 changes: 0 additions & 82 deletions chrome/content/scrollPatch/scrollMenus2.xul

This file was deleted.

2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"author": "Axel Grude, Klaus Buecher/opto",
"name" : "QuickFolders",
"description" : "__MSG_extensionDescription__",
"version" : "5.8.1",
"version" : "5.8.2",
"default_locale": "en",
"developer" : {
"name" : "Axel Grude, Klaus Buecher/opto",
Expand Down
11 changes: 6 additions & 5 deletions release-notes.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<b>Release 5.8.1</b>
<b>Release 5.8.2</b>
Please note that <b>QuickFolders is compatible with the latest version of Thunderbird (91.2)</b> - if you get a message that says otherwise after updating from earlier versions (Tb68 or Tb78) or <b>if QuickFolders cannot be enabled</b> with the blue slider, simply remove it and reinstall it via "Find more Add-ons" search box on the Extensions tab of Add-ons Manager.


Expand All @@ -9,18 +9,19 @@

You can also <a href="https://quickfolders.org/donate.html#donate">donate from here</a>.

<b>Maintenance Release 5.8.2</b>
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/5">[issue 5]</a> Long folders menus now scroll when dragging mails to screen edge.</li>

<b>Improvements</b>
<b>Improvements (5.8.1)</b>
<ul>
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/205">[issue 205]</a> When clicking "get Messages" from any tab, QuickFolders used to also jump into the folder. This behavior is actually not desired, as you may have filter rules defined which remove mail from the Inbox so jumping into the Inbox is not useful when new mail is downloaded. </li>
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/191">[issue 191]</a> Support large icon in QuickFolders toolbar buttons for high resolution displays. </li>
</ul>

<b>Bug Fixes + Miscellaneus</b>
<b>Bug Fixes + Miscellaneus (5.8.1)</b>
<ul>
<li>
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/211">[issue 211]</a> Fixed: move Folders in quickMove fails in Thunderbird 91. You can now again drag (multiple) folders from the tree to the quickMove button in order to relocate them. Or use the Shortcut Shift+M if you have a QuickFolders Pro license. </li>
<a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/203">[issue 203]</a> Fixed: When the quickFilters Add-on activates its assistant, all icons on left to the tabs on the QuickFolders toolbar turned white. </li>
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/203">[issue 203]</a> Fixed: When the quickFilters Add-on activates its assistant, all icons on left to the tabs on the QuickFolders toolbar turned white. </li>
<li>
<a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/209">[issue 209]</a> Fixed: Tabs in Options Dialog become illegible in Thunderbird 91 when using dark themes with bright text. </li>
<li>Fixed: In Thunderbird 91, background area behind current folder toolbar does not show correct background color from lightweight theme, even when lightweight support is enabled. </li>
Expand Down
2 changes: 1 addition & 1 deletion revision.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
99
16

0 comments on commit cebc97b

Please sign in to comment.