Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing for Genmoji Tapbacks in HTML exports #412

Open
ReagentX opened this issue Dec 18, 2024 · 1 comment · May be fixed by #416
Open

Add spacing for Genmoji Tapbacks in HTML exports #412

ReagentX opened this issue Dec 18, 2024 · 1 comment · May be fixed by #416
Assignees
Labels
bug Something isn't working crate: cli Related to the CLI crate html Related to HTML Export

Comments

@ReagentX
Copy link
Owner

ReagentX commented Dec 18, 2024

Genmoji sent as Tapbacks are missing a newline or a space between the sticker effect and the Genmoji prompt:

image

Interestingly, you can add a sticker effect to a normal sticker, but you can't add one to a Genmoji; perhaps for Genmoji we should omit the sticker effect text altogether.

This field will be populated with the prompt used to generate the Genmoji:

/// The prompt used to generate a Genmoji
pub emoji_description: Option<String>,

We can determine if an Attachment is a Genmoji by checking the sticker_user_info blob if the aforementioned field is populated:

image
@ReagentX ReagentX added bug Something isn't working crate: cli Related to the CLI crate html Related to HTML Export labels Dec 18, 2024
@ReagentX ReagentX self-assigned this Dec 18, 2024
@ReagentX ReagentX changed the title Genmoji Tapback HTML Missing Space/Newline Genmoji Tapbacks in HTML Exports Missing Space/Newline Dec 18, 2024
@ReagentX ReagentX changed the title Genmoji Tapbacks in HTML Exports Missing Space/Newline Genmoji Tapbacks in HTML Exports are Missing Space/Newline Dec 18, 2024
@ReagentX ReagentX changed the title Genmoji Tapbacks in HTML Exports are Missing Space/Newline Genmoji Tapbacks in HTML Exports are Missing a Space/Newline Dec 18, 2024
@ReagentX ReagentX changed the title Genmoji Tapbacks in HTML Exports are Missing a Space/Newline Add spacing for Genmoji Tapbacks in HTML exports Dec 18, 2024
@ReagentX
Copy link
Owner Author

Also worth noting that standalone stickers get the correct newlines:

image

ReagentX added a commit that referenced this issue Dec 25, 2024
@ReagentX ReagentX linked a pull request Dec 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crate: cli Related to the CLI crate html Related to HTML Export
Projects
Development

Successfully merging a pull request may close this issue.

1 participant