Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run more GHA on pull requests targeting any branch #6553

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Sep 30, 2024

Seen in #6432; stacked PRs will still benefit from seeing coverage reports up-stack.

Get consistent with the rest of the GHA for pull_request: trigger while we're here. cc @Anirban166, I didn't check to be 100% sure branches: '*' is the same as just not filtering by branch, but I think it is. Note that #6432 is running the atime tests.

@MichaelChirico MichaelChirico changed the title Run coverage on pull requests targeting any branch Run more GHA on pull requests targeting any branch Sep 30, 2024
@MichaelChirico MichaelChirico merged commit 7419796 into master Sep 30, 2024
8 checks passed
@MichaelChirico MichaelChirico deleted the ci-covr-all-branches branch September 30, 2024 06:03
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (aa04f90) to head (3ee630c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6553   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14448    14448           
=======================================
  Hits        14249    14249           
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Anirban166 Anirban166 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the * wildcard is redundant. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants