Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set _R_CHECK_TESTS_NLINES_=0 #6549

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Always set _R_CHECK_TESTS_NLINES_=0 #6549

merged 2 commits into from
Sep 29, 2024

Conversation

MichaelChirico
Copy link
Member

We should always dump the full error log, examining a failure like this one is much harder without it:

https://gitlab.com/Rdatatable/data.table/-/jobs/7943818835

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (ce9b5da) to head (d899f8e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6549   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14448    14448           
=======================================
  Hits        14249    14249           
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico merged commit aa04f90 into master Sep 29, 2024
8 checks passed
@MichaelChirico MichaelChirico deleted the glci-nlines branch September 29, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants