Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early returns to reduce nesting and improve readability #6542

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

MichaelChirico
Copy link
Member

Seen while reading for #6503

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (3734726) to head (6fb4e26).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6542   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14448    14449    +1     
=======================================
+ Hits        14249    14250    +1     
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Comparison Plot

Generated via commit 6fb4e26

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 3 minutes and 19 seconds

Time taken to run atime::atime_pkg on the tests: 8 minutes and 58 seconds

@MichaelChirico MichaelChirico changed the title Early returns to reduce nesting to improve readability Early returns to reduce nesting and improve readability Sep 28, 2024
Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks

@tdhock tdhock merged commit d62aac9 into master Oct 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants