# nocov for recent missed lines #6541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
requested review from
HughParsonage,
ben-schwen and
tdhock
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6541 +/- ##
==========================================
+ Coverage 97.02% 98.62% +1.59%
==========================================
Files 81 79 -2
Lines 14708 14443 -265
==========================================
- Hits 14271 14244 -27
+ Misses 437 199 -238 ☔ View full report in Codecov by Sentry. |
|
Generated via commit 00235aa Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 3 minutes and 30 seconds Time taken to run |
tdhock
approved these changes
Sep 27, 2024
| @@ -158,6 +158,7 @@ yaml=FALSE, autostart=NA, tmpdir=tempdir(), tz="UTC") | |||
| } | |||
| # whitespace at the beginning or end of na.strings is checked at C level and is an error there; test 1804 | |||
| } | |||
| # nocov start. Tested in other.Rraw tests 16, not in the main suite. | |||
There was a problem hiding this comment.
these kind of comments with references to test numbers in other files is great
|
thanks for your detailed analysis Michael |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6540, mainly to mark recently-missed lines with
# nocovas appropriate. There are three main sources of recent false positives:malloc()allocations succeeded: Consistently error when allocation request fails #6271default:lines fromswitch()as "uncovered". We might want to just dodefault: internal_error() // # nocov(i.e., all in one line vs. two consecutive# nocovlines)