-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: seal of approval entry for mlr3 #6430
Conversation
hi @m-muecke thanks for your PR. To add your package to this list, please submit a Pull Request to The Raft, making sure to follow the templated instructions: https://github.com/rdatatable-community/The-Raft/blob/main/.github/PULL_REQUEST_TEMPLATES/seal_of_approval.md Basically you would just have to write a short blog which explains what mlr3 does, and how it relates to data.table, like these: https://rdatatable-community.github.io/The-Raft/#category=seal%20of%20approval By the way, you are the first person who has submitted a package for the Seal of Approval, so we would appreciate any feedback you could share about how we could improve documentation for the submission process. For example, perhaps it would be helpful to directly link the templated instructions (https://github.com/rdatatable-community/The-Raft/blob/main/.github/PULL_REQUEST_TEMPLATES/seal_of_approval.md) from https://github.com/Rdatatable/data.table/blob/master/Seal_of_Approval.md ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
The draft post justifying this Seal is here: https://github.com/rdatatable-community/The-Raft/blob/main/posts/2024-09-24-seal_of_approval-mlr3/index.qmd Once this PR is merged, I will make the post live! |
hi @m-muecke your blog looks great to me, thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6430 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 79 79
Lines 14448 14448
=======================================
Hits 14249 14249
Misses 199 199 ☔ View full report in Codecov by Sentry. |
No description provided.