Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: seal of approval entry for mlr3 #6430

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Conversation

m-muecke
Copy link
Contributor

No description provided.

@tdhock
Copy link
Member

tdhock commented Aug 30, 2024

hi @m-muecke thanks for your PR.
I believe mlr3 is a great candidate to obtain the Seal of Approval.
However before we merge this PR, please first follow these instructions:

To add your package to this list, please submit a Pull Request to The Raft, making sure to follow the templated instructions: https://github.com/rdatatable-community/The-Raft/blob/main/.github/PULL_REQUEST_TEMPLATES/seal_of_approval.md

Basically you would just have to write a short blog which explains what mlr3 does, and how it relates to data.table, like these: https://rdatatable-community.github.io/The-Raft/#category=seal%20of%20approval

By the way, you are the first person who has submitted a package for the Seal of Approval, so we would appreciate any feedback you could share about how we could improve documentation for the submission process. For example, perhaps it would be helpful to directly link the templated instructions (https://github.com/rdatatable-community/The-Raft/blob/main/.github/PULL_REQUEST_TEMPLATES/seal_of_approval.md) from https://github.com/Rdatatable/data.table/blob/master/Seal_of_Approval.md ?

Copy link
Member

@Anirban166 Anirban166 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Anirban166

This comment was marked as off-topic.

@tdhock

This comment was marked as off-topic.

@Anirban166

This comment was marked as off-topic.

@Anirban166

This comment was marked as off-topic.

@tdhock

This comment was marked as off-topic.

@Anirban166

This comment was marked as off-topic.

@kbodwin
Copy link
Contributor

kbodwin commented Sep 27, 2024

The draft post justifying this Seal is here: https://github.com/rdatatable-community/The-Raft/blob/main/posts/2024-09-24-seal_of_approval-mlr3/index.qmd

Once this PR is merged, I will make the post live!

@tdhock
Copy link
Member

tdhock commented Sep 28, 2024

hi @m-muecke your blog looks great to me, thanks for your contribution!

@tdhock tdhock merged commit e8a4e2d into Rdatatable:master Sep 28, 2024
8 checks passed
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (fcc9de2) to head (dc21d02).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6430   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14448    14448           
=======================================
  Hits        14249    14249           
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants