Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fwrite length for gzip output #6393

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Fix fwrite length for gzip output #6393

wants to merge 43 commits into from

Commits on Aug 22, 2024

  1. fwrite with correct file length 

    * gzip length and crc are manually computed in each thread and then
  added/combined

* gzip header is minimal

* remove some old debug code
    @philippechataignon
    philippechataignon committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fcc10d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Escape with NOZLIB for compilation succeed without zlib

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    97c919b View commit details
    Browse the repository at this point in the history

  2. Move zlib check at start to avoid oufile deletion

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4914d7a View commit details
    Browse the repository at this point in the history

  3. Indent and add comments

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d9e9e92 View commit details
    Browse the repository at this point in the history

  4. Buffers unification

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c8970e1 View commit details
    Browse the repository at this point in the history

  5. Restore schedule(dynamic) more efficient and progress

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2fc184e View commit details
    Browse the repository at this point in the history

  6. Use alloc_size to see allocation when verbose

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    47c16f2 View commit details
    Browse the repository at this point in the history

  7. Test if stream init succeded

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3dcb7d6 View commit details
    Browse the repository at this point in the history

  8. Add cast to avoid warnings on Windows

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6569cfe View commit details
    Browse the repository at this point in the history

  9. More explicit timing messages

    @philippechataignon
    philippechataignon committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    bae11e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Free stream structs

    @philippechataignon
    philippechataignon committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    5ce31f3 View commit details
    Browse the repository at this point in the history

  2. Add option to control compression level for fwrite with gzip

    @ben-schwen @philippechataignon
    ben-schwen authored and philippechataignon committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b07306f View commit details
    Browse the repository at this point in the history

  3. Rework namings and default value

    @ben-schwen @philippechataignon
    ben-schwen authored and philippechataignon committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    8722519 View commit details
    Browse the repository at this point in the history

  4. Rename gzipLevel to compressLevel

    @philippechataignon
    philippechataignon committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0800f10 View commit details
    Browse the repository at this point in the history

  5. compressLevel param documentation

    @philippechataignon
    philippechataignon committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a0a9c1f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Put zlib initialization together

    @philippechataignon
    philippechataignon committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    a00761d View commit details
    Browse the repository at this point in the history

  2. Refact buffSize, numBatchs and numBatches

    @philippechataignon
    philippechataignon committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    aaf85ab View commit details
    Browse the repository at this point in the history

  3. Add missing NOZLIB

    @philippechataignon
    philippechataignon committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    478b862 View commit details
    Browse the repository at this point in the history

  4. Increase outputs in last message when verbose

    @philippechataignon
    philippechataignon committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    b09aa34 View commit details
    Browse the repository at this point in the history

  5. No real init for stream_thread when is_gzip false

    @philippechataignon
    philippechataignon committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    669eb01 View commit details
    Browse the repository at this point in the history

  6. Minor corrections

    @philippechataignon
    philippechataignon committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    5668431 View commit details
    Browse the repository at this point in the history

  7. Uses %zu format for size_t

    @philippechataignon
    philippechataignon committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    e9e2e83 View commit details
    Browse the repository at this point in the history

  8. Last verbose msg was not printed when not is_gzip

    @philippechataignon
    philippechataignon committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    7fb8738 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. minor operator ws change

    @MichaelChirico
    MichaelChirico authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    024a34d View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Add test for compressLevel=1

    @philippechataignon
    philippechataignon committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2fe3099 View commit details
    Browse the repository at this point in the history

  2. Add url link in compressLevel documentation

    @philippechataignon
    philippechataignon committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e9f2861 View commit details
    Browse the repository at this point in the history

  3. Add 2 lines in NEWS for fwrite fix and compressLevel

    @philippechataignon
    philippechataignon committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6a75749 View commit details
    Browse the repository at this point in the history

  4. tidy-up, expand NEWS for compressLevel

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4936e45 View commit details
    Browse the repository at this point in the history

  5. Use match.arg() for arg validation

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6b76bea View commit details
    Browse the repository at this point in the history

  6. add a test for the other extreme compressLevel=9

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    eede93f View commit details
    Browse the repository at this point in the history

  7. partial test fix

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e39259c View commit details
    Browse the repository at this point in the history

  8. fix updated test errors

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    182432b View commit details
    Browse the repository at this point in the history

  9. confirmed NEWS wording, fix typo

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6999dc6 View commit details
    Browse the repository at this point in the history

  10. fix order

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    47464db View commit details
    Browse the repository at this point in the history

  11. weak ordering

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e2e7022 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into fix_fwrite_length

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c4971f5 View commit details
    Browse the repository at this point in the history

  13. place in 1.17.0 NEWS

    @MichaelChirico
    MichaelChirico authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6bebfc2 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Add parenthesis to be more explicit

    @philippechataignon
    philippechataignon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5687a0c View commit details
    Browse the repository at this point in the history

  2. Add comment for DeflateInit2

    @philippechataignon
    philippechataignon committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    117ab45 View commit details
    Browse the repository at this point in the history

  3. typo

    @MichaelChirico
    MichaelChirico authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4e91a21 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix_fwrite_length

    @MichaelChirico
    MichaelChirico authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    45bf1d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Add parenthesis to be more explicit (2) 

    Co-authored-by: Michael Chirico <chiricom@google.com>
    @philippechataignon @MichaelChirico
    philippechataignon and MichaelChirico authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    255f1ce View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'master' into fix_fwrite_length

    @MichaelChirico
    MichaelChirico authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    cdf4277 View commit details
    Browse the repository at this point in the history