Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showProgress --> show.progress for "by" operations #6372

Closed
wants to merge 2 commits into from
Closed

Conversation

joshhwuu
Copy link
Member

Closes #6371

Updated progress printing argument to be more consistent with other arguments in [ (at least not introducing another naming style).

Copy link

github-actions bot commented Aug 16, 2024

Comparison Plot

Generated via commit ea08f83

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 45 seconds

Time taken to run atime::atime_pkg on the tests: 5 minutes and 53 seconds

Copy link
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MichaelChirico
Copy link
Member

closing as discussed #6371

@MichaelChirico MichaelChirico deleted the fix6371 branch August 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename showProgress argument to [
4 participants