Seal of Approval additions #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seal_of_Approval.md created and added to R build ignore
- Add link to Seal of Approval doc - Add links to social media accounts and The Raft
Three packages proposed for Seal: - nc: By Toby, adds regular expressions to data.table - tidyfast: By Tyson, implements dplyr-like verbs with only data.table as a dependency - dtplyr: By Hadley, adds data.table backend to dplyr verbs. Merging of this PR by a maintainer will consistute Approval on these three packages!
Anirban166
reviewed
Aug 14, 2024
|
looks good to me, thanks Kelly. |
jangorecki
reviewed
Aug 16, 2024
|
Looks good, left one minor comment |
|
great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR'ing to add the Seal_of_Approval.md document that keeps a list of approved packages, as well as proposing the first three pilot packages for approval.
(Also updating R Build Ignore and README accordingly.)