Remove logical condition recycling from fcase() #6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated via commit 4459862 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 12 minutes and 11 seconds Time taken to run |
tdhock
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
looks good, nice NEWS item.
you may want to ask @DavisVaughan for review too?
|
I'm not sure he's reviewed code here before so it might take some effort to parse through it. I think the high-level feedback he gave leading to this was clear enough & implemented here. But Davis, do feel free to chime in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6352 as discussed.
Not a big fan of the need for
suppressWarnings()in the R body;...length()is the way to avoid this, but that's not available till R3.5.0.