-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove check for unavailabe dependencies on ancient R #6362
Conversation
This feels a bit fragile to me. I wonder what the practical use case we're testing for is exactly:
I've worked towards the latter in the R-CMD-check-occasional GHA, and taken the approach to just skip stuff related to these Suggests deps that won't install: data.table/.github/workflows/R-CMD-check-occasional.yaml Lines 144 to 148 in 83fd2c0
(I don't really have a sense one way or the other what's more likely) |
Number 2 seems the way to go and also simplifies it! |
Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! May as well merge #6383 first, right? Since we know CI will fail on 3.3.0 at current master
.
Current CI ancient job is failing because new version of
xts
, andevaluate
depend onR 4.0.0
. This PR patches the CI job by installing fixed versions for certain packages, afterwards.