-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor C linters for better extensibility/reuse #6346
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MichaelChirico and the rest of your teammates on Graphite |
.ci/linters/c/alloc_linter.R
Outdated
alloc_linter = function(c_file) { | ||
lines <- readLines(c_file) | ||
alloc_linter = function(c_obj) { | ||
lines <- c_obj$lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know its not directly data.table
but still feels strange that we do not use =
for assignment in this file (style linting the linter files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (besides <-
and =
mix)
Merge activity
|
Most importantly, we can run
readLines()
+ preprocess the file only once, then pass that output to each linter.