From 30839cd32a90614a4210a4fe38d6a912db8b3628 Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Tue, 16 Jul 2024 17:56:11 -0700 Subject: [PATCH 1/5] Update tests.R --- .ci/atime/tests.R | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index fddfb1347..4ea2ebbe7 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -119,6 +119,26 @@ test.list <- atime::atime_test_list( data.table:::setDT(L) }, Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) - Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) + Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"), # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) + + # Issue reported in: https://github.com/Rdatatable/data.table/issues/3735 + # To be fixed in: https://github.com/Rdatatable/data.table/pull/4488 + "Selecting from data.table by row is very slow #4488" = atime::atime_test( + N = 10^seq(1, 20), + setup = { + allIterations <- data.frame(v1 = runif(N), v2 = runif(N)) + DoSomething <- function(row) { + someCalculation <- row[["v1"]] + 1 + } + allIteration_dt <- as.data.table(allIterations) + setDTthreads(1) + }, + expr = { + for (r in 1:nrow(allIterations)) { + DoSomething(data.table:::`[.data.table`(allIterations, r, )) + } + }, + slow="d47a83fb2e25582e508f191f87a31ca81b736b57",#Parent of the first commit in the PR that fixes the issue + fast="958e3dd3cba7c259220aa653bef4beb8ad74b239") # last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/4488/commits) ) # nolint end: undesirable_operator_linter. From 03f1f5ec43afa3e89203db96521190b159e4b380 Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Wed, 17 Jul 2024 09:32:53 -0700 Subject: [PATCH 2/5] Updated commit comments --- .ci/atime/tests.R | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 4ea2ebbe7..da7414054 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -123,7 +123,7 @@ test.list <- atime::atime_test_list( # Issue reported in: https://github.com/Rdatatable/data.table/issues/3735 # To be fixed in: https://github.com/Rdatatable/data.table/pull/4488 - "Selecting from data.table by row is very slow #4488" = atime::atime_test( + "Selecting from data.table by row improved in #4488" = atime::atime_test( N = 10^seq(1, 20), setup = { allIterations <- data.frame(v1 = runif(N), v2 = runif(N)) @@ -138,7 +138,7 @@ test.list <- atime::atime_test_list( DoSomething(data.table:::`[.data.table`(allIterations, r, )) } }, - slow="d47a83fb2e25582e508f191f87a31ca81b736b57",#Parent of the first commit in the PR that fixes the issue - fast="958e3dd3cba7c259220aa653bef4beb8ad74b239") # last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/4488/commits) + slow = "d47a83fb2e25582e508f191f87a31ca81b736b57",# Parent of the first commit (https://github.com/Rdatatable/data.table/commit/c33e98bb0a2f919bc1b428a5b7985f45f9d88a77) in the PR (https://github.com/Rdatatable/data.table/pull/4488/commits) that fixes the issue + fast = "958e3dd3cba7c259220aa653bef4beb8ad74b239") # last commit in the PR (https://github.com/Rdatatable/data.table/pull/4488/commits) that fixes the issue ) # nolint end: undesirable_operator_linter. From 398f32006637448a0927a019eb893f2e8c7e957a Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Wed, 17 Jul 2024 12:19:45 -0700 Subject: [PATCH 3/5] Updated test name --- .ci/atime/tests.R | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index da7414054..3efd039e4 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -123,7 +123,7 @@ test.list <- atime::atime_test_list( # Issue reported in: https://github.com/Rdatatable/data.table/issues/3735 # To be fixed in: https://github.com/Rdatatable/data.table/pull/4488 - "Selecting from data.table by row improved in #4488" = atime::atime_test( + "Row-wise selection improved in #4488" = atime::atime_test( N = 10^seq(1, 20), setup = { allIterations <- data.frame(v1 = runif(N), v2 = runif(N)) @@ -138,7 +138,7 @@ test.list <- atime::atime_test_list( DoSomething(data.table:::`[.data.table`(allIterations, r, )) } }, - slow = "d47a83fb2e25582e508f191f87a31ca81b736b57",# Parent of the first commit (https://github.com/Rdatatable/data.table/commit/c33e98bb0a2f919bc1b428a5b7985f45f9d88a77) in the PR (https://github.com/Rdatatable/data.table/pull/4488/commits) that fixes the issue - fast = "958e3dd3cba7c259220aa653bef4beb8ad74b239") # last commit in the PR (https://github.com/Rdatatable/data.table/pull/4488/commits) that fixes the issue + Slow = "d47a83fb2e25582e508f191f87a31ca81b736b57",# Parent of the first commit (https://github.com/Rdatatable/data.table/commit/c33e98bb0a2f919bc1b428a5b7985f45f9d88a77) in the PR (https://github.com/Rdatatable/data.table/pull/4488/commits) that fixes the issue + Fast = "958e3dd3cba7c259220aa653bef4beb8ad74b239") # last commit in the PR (https://github.com/Rdatatable/data.table/pull/4488/commits) that fixes the issue ) # nolint end: undesirable_operator_linter. From 43336d7e44fafb78ad24a59753881d078c85c28d Mon Sep 17 00:00:00 2001 From: Doris Amoakohene Date: Mon, 29 Jul 2024 11:35:42 -0700 Subject: [PATCH 4/5] updated test name and spacing --- .ci/atime/tests.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 3efd039e4..e8e4ff3f9 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -138,7 +138,7 @@ test.list <- atime::atime_test_list( DoSomething(data.table:::`[.data.table`(allIterations, r, )) } }, - Slow = "d47a83fb2e25582e508f191f87a31ca81b736b57",# Parent of the first commit (https://github.com/Rdatatable/data.table/commit/c33e98bb0a2f919bc1b428a5b7985f45f9d88a77) in the PR (https://github.com/Rdatatable/data.table/pull/4488/commits) that fixes the issue - Fast = "958e3dd3cba7c259220aa653bef4beb8ad74b239") # last commit in the PR (https://github.com/Rdatatable/data.table/pull/4488/commits) that fixes the issue + Slow = "d47a83fb2e25582e508f191f87a31ca81b736b57", # Parent of the first commit ( https://github.com/Rdatatable/data.table/commit/c33e98bb0a2f919bc1b428a5b7985f45f9d88a77 ) in the PR ( https://github.com/Rdatatable/data.table/pull/4488/commits ) that fixes the issue + Fast = "958e3dd3cba7c259220aa653bef4beb8ad74b239") # last commit in the PR ( https://github.com/Rdatatable/data.table/pull/4488/commits ) that fixes the issue ) # nolint end: undesirable_operator_linter. From e459e999a7791b2712b100ddd4d8273cab3b51ae Mon Sep 17 00:00:00 2001 From: Ani Date: Fri, 13 Sep 2024 14:06:03 -0700 Subject: [PATCH 5/5] Test case title --- .ci/atime/tests.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index e8e4ff3f9..289e2596f 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -123,7 +123,7 @@ test.list <- atime::atime_test_list( # Issue reported in: https://github.com/Rdatatable/data.table/issues/3735 # To be fixed in: https://github.com/Rdatatable/data.table/pull/4488 - "Row-wise selection improved in #4488" = atime::atime_test( + "DT[i] improved in #4488" = atime::atime_test( N = 10^seq(1, 20), setup = { allIterations <- data.frame(v1 = runif(N), v2 = runif(N))