Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding an atime test case; groupby with dogroups (R expression) #PR4558 #6288

Merged
merged 10 commits into from
Jul 29, 2024
Merged

adding an atime test case; groupby with dogroups (R expression) #PR4558 #6288

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c898b5b
Update tests.R
DorisAmoakohene Jul 17, 2024
e16f001
Update tests.R
DorisAmoakohene Jul 17, 2024
951bfcf
Update to commit links
DorisAmoakohene Jul 17, 2024
64f908e
Before commits comment updated
DorisAmoakohene Jul 17, 2024
6075ca0
new comment to the before commit
DorisAmoakohene Jul 18, 2024
4dbbf0c
Update tests.R
DorisAmoakohene Jul 18, 2024
af2fa84
Removed extra spacing in some comments
DorisAmoakohene Jul 29, 2024
ea22668
Fixed tense error and spacing
DorisAmoakohene Jul 29, 2024
1e1f4e0
updated fixed commit description
DorisAmoakohene Jul 29, 2024
91671e4
Merge branch 'master' into adding-a-new-test-for-regression-for-4558
tdhock Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ test.list <- atime::atime_test_list(

# Issue reported in: https://github.com/Rdatatable/data.table/issues/5426
# To be fixed in: https://github.com/Rdatatable/data.table/pull/5427
"setDT improved in #5427" = atime::atime_test(
"setDT improved fixed in #5427" = atime::atime_test(
DorisAmoakohene marked this conversation as resolved.
Show resolved Hide resolved
N = 10^seq(1, 7),
setup = {
L <- replicate(N, 1, simplify = FALSE)
Expand All @@ -119,6 +119,25 @@ test.list <- atime::atime_test_list(
data.table:::setDT(L)
},
Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801)
Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits)
Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"), # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits)

# Issue reported in: https://github.com/Rdatatable/data.table/issues/4200
# To be fixed in: https://github.com/Rdatatable/data.table/pull/4558
"DT[by] fixed in #4558" = atime::atime_test(
N = 10^seq(1, 20),
setup = {
d <- data.table(
id3 = sample( c(seq.int(N*0.9), sample( N*0.9, N*0.1, TRUE))),
DorisAmoakohene marked this conversation as resolved.
Show resolved Hide resolved
v1 = sample(5L, N, TRUE),
v2 = sample(5L, N, TRUE)
)
},
expr = {
expr=data.table:::`[.data.table`(d, , (max(v1)-min(v2)), by = id3)
},
Before="793f8545c363d222de18ac892bc7abb80154e724", # Parent of the PR that introduced the regression(https://github.com/Rdatatable/data.table/commit/4aadde8f5a51cd7c8f3889964e7280432ec65bbc) as stated here (https://github.com/Rdatatable/data.table/issues/4200#issuecomment-646111420) https://github.com/Rdatatable/data.table/commit/793f8545c363d222de18ac892bc7abb80154e724
tdhock marked this conversation as resolved.
Show resolved Hide resolved
Regression="c152ced0e5799acee1589910c69c1a2c6586b95d", # Parent of the first commit(https://github.com/Rdatatable/data.table/pull/4558/commits/15f0598b9828d3af2eb8ddc9b38e0356f42afe4f) in the PR (https://github.com/Rdatatable/data.table/pull/4558/commits)
DorisAmoakohene marked this conversation as resolved.
Show resolved Hide resolved
Fixed="f750448a2efcd258b3aba57136ee6a95ce56b302") # Second commit (https://github.com/Rdatatable/data.table/tree/f750448a2efcd258b3aba57136ee6a95ce56b302) in the PR that fixes the regression(https://github.com/Rdatatable/data.table/pull/4558/commits)
DorisAmoakohene marked this conversation as resolved.
Show resolved Hide resolved
)

# nolint end: undesirable_operator_linter.
Loading