-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding an atime test case; groupby with dogroups (R expression) #PR4558 #6288
Conversation
Generated via commit 91671e4 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 11 minutes and 55 seconds Time taken to run |
@tdhock, 6288 is the right one, when I trying renaming the branch it create a new PR, I think that's the reason for the duplicate, but I am still figuring how I can rename the branch without duplicating the test |
@tdhock, Kindly see the updates, so I can submit the other PR |
Both commits in this PR have message "Update tests.R" which may be confusing to others trying to review your PR.
|
hi @Anirban166 can you please help by reviewing and giving suggestions about how to improve this PR? |
Hi @tdhock and @Anirban166 could you review this for merge. |
There are still pending reviews/comments that you need to push changes for |
I was supposed to update the comment for the Commit id, and I have |
please click Files Changed tab, and read comments, then push commit(s) that address those comments. |
This test case discusses the issue reported on performing group computations, specifically when running R's C eval on each group (q7 and q8) in the db-benchmark, indicating a slowness in the implementation of the code. #4200
This is the #4558 that discusses the Cause of the Regression: #4200 (comment) which appears that the regression occurred during the evaluation of C code within these particular groups, indicating a performance issue or slowness in the implementation of the code.
The regression was fixed Regression by the addition of const int nth = getDTthreads