Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an atime test case; groupby with dogroups (R expression) #PR4558 #6288

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

DorisAmoakohene
Copy link
Contributor

This test case discusses the issue reported on performing group computations, specifically when running R's C eval on each group (q7 and q8) in the db-benchmark, indicating a slowness in the implementation of the code. #4200

This is the #4558 that discusses the Cause of the Regression: #4200 (comment) which appears that the regression occurred during the evaluation of C code within these particular groups, indicating a performance issue or slowness in the implementation of the code.

The regression was fixed Regression by the addition of const int nth = getDTthreads

Copy link

github-actions bot commented Jul 17, 2024

Comparison Plot

Generated via commit 91671e4

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 55 seconds

Time taken to run atime::atime_pkg on the tests: 6 minutes and 5 seconds

.ci/atime/tests.R Outdated Show resolved Hide resolved
@DorisAmoakohene
Copy link
Contributor Author

@tdhock, 6288 is the right one, when I trying renaming the branch it create a new PR, I think that's the reason for the duplicate, but I am still figuring how I can rename the branch without duplicating the test

.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
@DorisAmoakohene
Copy link
Contributor Author

DorisAmoakohene commented Jul 17, 2024

@tdhock, Kindly see the updates, so I can submit the other PR

@tdhock
Copy link
Member

tdhock commented Jul 17, 2024

Both commits in this PR have message "Update tests.R" which may be confusing to others trying to review your PR.
Please use

git commit -m "More specific commit message which is a short description of the changes that you made"

.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
@Rdatatable Rdatatable deleted a comment from tdhock Jul 17, 2024
.ci/atime/tests.R Outdated Show resolved Hide resolved
@tdhock
Copy link
Member

tdhock commented Jul 18, 2024

hi @Anirban166 can you please help by reviewing and giving suggestions about how to improve this PR?

.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
@DorisAmoakohene
Copy link
Contributor Author

Hi @tdhock and @Anirban166 could you review this for merge.

@Anirban166
Copy link
Member

There are still pending reviews/comments that you need to push changes for

@DorisAmoakohene
Copy link
Contributor Author

There are still pending reviews/comments that you need to push changes for

I was supposed to update the comment for the Commit id, and I have

@tdhock
Copy link
Member

tdhock commented Jul 29, 2024

please click Files Changed tab, and read comments, then push commit(s) that address those comments.

.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
@tdhock tdhock merged commit 72b78c9 into master Jul 29, 2024
5 checks passed
@tdhock tdhock deleted the adding-a-new-test-for-regression-for-4558 branch July 29, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants