Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an atime test case; groupby with dogroups (R expression) #PR4558 #6287

Closed
wants to merge 1 commit into from

Conversation

DorisAmoakohene
Copy link
Contributor

This test case discusses the issue reported on performing group computations, specifically when running R's C eval on each group (q7 and q8) in the db-benchmark, indicating a slowness in the implementation of the code. #4200

This is the #4558 that discusses the Cause of the Regression: #4200 (comment) which appears that the regression occurred during the evaluation of C code within these particular groups, indicating a performance issue or slowness in the implementation of the code.

The regression was fixed Regression by the addition of const int nth = getDTthreads

@DorisAmoakohene DorisAmoakohene deleted the DorisAmoakohene-patch-2 branch July 17, 2024 00:37
Copy link

Comparison Plot

Generated via commit c898b5b

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 12 minutes and 5 seconds

Time taken to run atime::atime_pkg on the tests: 4 minutes and 40 seconds

@tdhock
Copy link
Member

tdhock commented Jul 17, 2024

why is there another similar (identical?) PR #6288 ?
If there is no difference, please only make one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants