Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use malloc() over variable-length array #6270

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Use malloc() over variable-length array #6270

merged 6 commits into from
Jul 16, 2024

Conversation

MichaelChirico
Copy link
Member

Closes #5528

@MichaelChirico MichaelChirico added this to the 1.16.0 milestone Jul 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Comparison Plot

Generated via commit 3318f17

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 58 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 26 seconds

tdhock
tdhock approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks

@MichaelChirico MichaelChirico merged commit 6cc6d53 into master Jul 16, 2024
4 of 5 checks passed
@MichaelChirico MichaelChirico deleted the vla branch July 16, 2024 14:18
@MichaelChirico MichaelChirico mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdhock tdhock tdhock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Variable-length array compilation failure under -Werror
2 participants
@MichaelChirico @tdhock