Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rchk GHA #6263

Merged
merged 28 commits into from
Aug 5, 2024
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
9b36e67
Create rchk GHA
MichaelChirico Jul 15, 2024
a23891d
fix yaml config
MichaelChirico Jul 15, 2024
3c398bf
Add a name, try 'ls'
MichaelChirico Jul 15, 2024
785092e
plain ls output not shown...
MichaelChirico Jul 15, 2024
84c2011
missing checkout step
MichaelChirico Jul 15, 2024
1fea14e
Merge branch 'master' into rchk-gha
MichaelChirico Jul 21, 2024
c2aa752
Ensure we're not UNPROTECT()ing 'x'
MichaelChirico Jul 21, 2024
9eb49ff
Merge branch 'rchk-protect-stack' into rchk-gha
MichaelChirico Jul 22, 2024
1af6a5f
Merge remote-tracking branch 'origin/master' into rchk-gha
MichaelChirico Jul 22, 2024
ce8c256
Couple shots in the dark...
MichaelChirico Jul 22, 2024
cd2b429
more redundancy...for now...
MichaelChirico Jul 22, 2024
9e607cd
separate UNPROTECT()?
MichaelChirico Jul 22, 2024
86b5c0c
incidental: fix test numbering
MichaelChirico Jul 23, 2024
51caab5
attempt
MichaelChirico Jul 23, 2024
c965eb5
Revert "attempt"
MichaelChirico Jul 23, 2024
b62c2da
Merge branch 'master' into rchk-gha
ben-schwen Jul 25, 2024
1784104
a clean a tempt at PROTECT() inside if
MichaelChirico Jul 26, 2024
77f0547
Revert "a clean a tempt at PROTECT() inside if"
MichaelChirico Jul 26, 2024
4832c60
does it not like consecutive UNPROTECT() calls?
MichaelChirico Jul 29, 2024
cbecfae
PROTECT() more in forder+bmerge
MichaelChirico Jul 29, 2024
f9335c2
Merge branch 'master' into rchk-gha
MichaelChirico Jul 29, 2024
14c9900
Exclude "results will be incomplete" hits (but always dump output)
MichaelChirico Jul 29, 2024
5e38680
Merge branch 'master' into rchk-gha
MichaelChirico Jul 29, 2024
c3d4ca4
Merge remote-tracking branch 'origin/rchk-forder' into rchk-gha
MichaelChirico Jul 29, 2024
56b0023
-F everything
MichaelChirico Jul 29, 2024
eff76e1
Merge branch 'master' into rchk-gha
MichaelChirico Jul 29, 2024
c5d5241
Merge branch 'master' into rchk-gha
MichaelChirico Aug 5, 2024
07b46f5
manual revert faulty merge
MichaelChirico Aug 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions .github/workflows/rchk.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# adapted from a similar check run by {arrow}
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
on:
push:
branches:
- master
pull_request:

name: 'rchk'

jobs:
rchk:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: r-lib/actions/setup-r@v2
with:
r-version: 'devel'
- name: Build
run: |
ls -l | cat
R CMD build --no-build-vignettes .
mkdir packages
mv data.table_*.tar.gz packages
- name: Run rchk
run: |
docker run -v `pwd`/packages:/rchk/packages kalibera/rchk:latest /rchk/packages/data.table_*.tar.gz |& tee rchk.out
- name: Confirm that rchk has no errors
# Suspicious call, [UP], and [PB] are all of the error types currently at
# https://github.com/kalibera/cran-checks/tree/HEAD/rchk/results
# though this might not be exhaustive, there does not appear to be a way to have rchk return an error code
# CRAN also will remove some of the outputs (especially those related to Rcpp and strptime, e.g.
# ERROR: too many states (abstraction error?))
# https://github.com/kalibera/rchk
run: |
cat rchk.out
if [ $(grep -Fc "Suspicious call" rchk.out) -gt 0 ] || [ $(grep -F "[UP]" rchk.out | grep -Fvc "results will be incomplete") -gt 0 ] || [ $(grep -Fc "[PB]" rchk.out) -gt 0 ]; then
echo "Found rchk errors"
exit 1
fi
if: always()
- name: Dump rchk output logs
run: cat rchk.out
if: always()
Loading