call correct which= in sys.call()

[MichaelChirico]

sys.call(1) actually pulls from the top of the stack (i.e., equivalent to sys.calls()[[1]]), but we need to pull from the bottom, hence sys.nframe().

Before:

DT=data.table(a=1, b=2)
setnames(DT, c(NA, 'b'), c('c', 'd'))
# Error in stopf("NA (or out of bounds) in 'old' at positions %s", brackify(which(is.na(old)))) : 
#   NA (or out of bounds) in 'old' at positions [1]

foo = function() {
  setnames(DT, c(NA, 'b'), c('c', 'd'))
}
foo()
# Error in setnames(DT, c(NA, "b"), c("c", "d")) : 
#   NA (or out of bounds) in 'old' at positions [1]

After:

DT=data.table(a=1, b=2)
setnames(DT, c(NA, 'b'), c('c', 'd'))
# Error in setnames(DT, c(NA, "b"), c("c", "d")) : 
#   NA (or out of bounds) in 'old' at positions [1]

foo = function() {
  setnames(DT, c(NA, 'b'), c('c', 'd'))
}
foo()
# Error in setnames(DT, c(NA, "b"), c("c", "d")) : 
#   NA (or out of bounds) in 'old' at positions [1]

[github-actions]

Generated via commit 6caf66a

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 32 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 37 seconds

[TysonStanley]

Makes sense that the usage of raise_condition() would consistently be 2 from the bottom of the stack (but in theory could be anywhere from the top)