Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor calls to "print.default" within "print.data.table" #6091

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

joshhwuu
Copy link
Member

Closes #6089

Need discussion on what to name the factored function, currently print_default(), and whether to put it inside the print.data.table body or outside as a helper

Copy link

github-actions bot commented Apr 16, 2024

Comparison Plot

Generated via commit 53da5d9

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 35 seconds

Time taken to run atime::atime_pkg on the tests: 2 minutes and 33 seconds

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@MichaelChirico MichaelChirico merged commit 47a7f52 into master Apr 17, 2024
4 checks passed
@MichaelChirico MichaelChirico deleted the refactorprints branch April 17, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid repetitive calls to print() [default] inside print.data.table()
2 participants