-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore comma-separated columns to by= and key= #6049
Conversation
This reverts commit b6d6100.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6049 +/- ##
=======================================
Coverage 97.52% 97.53%
=======================================
Files 80 80
Lines 14978 14916 -62
=======================================
- Hits 14607 14548 -59
+ Misses 371 368 -3 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…d hard deprecation
Generated via commit 636e91b Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 11 minutes and 47 seconds Time taken to run |
OK, updated this PR to be a reversion to bring back 1.15.0 behavior. Thanks @HughParsonage for pushing back on the breaking change :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine with me, thanks
As discussed in #4357, there's not an urgent need to break back-compatibility here. We might reconsider for data.table 2.0.
This PR restores the functionality removed by #6047, and adds a helper function to at least have a unified approach across the 3 call sites.
We don't need to revert / undo any of the suggested changes to downstream packages -- it's still a good practice to use the character vector approach in package code, and we mainly maintain the "CSV" approach as a convenience for interactive usage.