Use deparse() to cast calls to string when needed #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColeMiller1
reviewed
Mar 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6027 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 80 80
Lines 14915 14917 +2
=======================================
+ Hits 14547 14549 +2
Misses 368 368 ☔ View full report in Codecov by Sentry. |
MichaelChirico
commented
Mar 28, 2024
MichaelChirico
changed the title
|
Generated via commit 5ba6112 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 11 minutes and 30 seconds Time taken to run |
|
@jangorecki PTAL, straightforward enough. I do worry about deeper edgecases, would be good to put this through revdeps. |
|
I would go back to the issue and examine if what the problem exactly is and possible solutions. |
jangorecki
approved these changes
Jul 29, 2024
jangorecki
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6026.
There is some small overhead added here since
jsub %iscall% fcallsis.call()redundantly a few times.is.call()is ~50ns to run so I think this can be ignored.