Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

last/first get argument na.rm #5168

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

last/first get argument na.rm #5168

wants to merge 49 commits into from

Commits on Sep 18, 2021

  1. new syntax

    @ben-schwen
    ben-schwen committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    f976102 View commit details
    Browse the repository at this point in the history

  2. add coverage

    @ben-schwen
    ben-schwen committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    a2c067a View commit details
    Browse the repository at this point in the history

  3. added consistency

    @ben-schwen
    ben-schwen committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    8968895 View commit details
    Browse the repository at this point in the history

  4. add coverage

    @ben-schwen
    ben-schwen committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    69d90a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. update .SD optimization

    @ben-schwen
    ben-schwen committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    6355d63 View commit details
    Browse the repository at this point in the history

  2. merge master

    @ben-schwen
    ben-schwen committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    16b16f6 View commit details
    Browse the repository at this point in the history

  3. coverage

    @ben-schwen
    ben-schwen committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    dcf49ba View commit details
    Browse the repository at this point in the history

  4. update docs

    @ben-schwen
    ben-schwen committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    7966d57 View commit details
    Browse the repository at this point in the history

  5. fix NEWS

    @ben-schwen
    ben-schwen committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    c5d2bc0 View commit details
    Browse the repository at this point in the history

  6. update tests

    @ben-schwen
    ben-schwen committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    be5a1f1 View commit details
    Browse the repository at this point in the history

  7. turn on lapply optimization for head/tail

    @ben-schwen
    ben-schwen committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    c6c1d42 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. merge master

    @mattdowle
    mattdowle committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    b04b51f View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Merge branch 'master' into last_narm

    @mattdowle
    mattdowle committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    91bae5e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into last_narm

    @mattdowle
    mattdowle committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    3a45476 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Merge branch 'master' into last_narm

    @mattdowle
    mattdowle committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    6d52148 View commit details
    Browse the repository at this point in the history

  2. creating 'c' variable in new tests caused cc() to fail on test 1035.0… 

    …1 (melt) with 'match.call(fun, orig_call): invalid definition argument' after running the new tests at the prompt; so removed variables and created DT directly in new tests
    @mattdowle
    mattdowle committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    384da9b View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. remove && \!narm_arg(first, jsub) temporarily to confirm it wasn't te… 

    …sted
    @mattdowle
    mattdowle committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    dad0537 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. rework tests & last.R, add na.rm='row'

    @mattdowle
    mattdowle committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    58195f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. add TRUE/'row' to news item, add last(.SD) tests by group

    @mattdowle
    mattdowle committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    d8e76e4 View commit details
    Browse the repository at this point in the history

  2. .(last(one col), first(another col)) by group optimized

    @mattdowle
    mattdowle committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    75676b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. n>1 with na.rm=TRUE too added to gfirst and glast, reworked gforce_ok… 

    … to use named arguments now that n and na.rm can be items 3 and 4 with either appearing first
    @mattdowle
    mattdowle committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    e520cab View commit details
    Browse the repository at this point in the history

  2. added 18.7s down to 0.1s example to news item

    @mattdowle
    mattdowle committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    0a07595 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. test first/last of .SD with na.rm=TRUE and na.rm='row' by group with … 

    …n>1 too
    @mattdowle
    mattdowle committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    792d948 View commit details
    Browse the repository at this point in the history

  2. test error if n<0

    @mattdowle
    mattdowle committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    a2292ff View commit details
    Browse the repository at this point in the history

  3. add to news item prior syntax for na.rm='row'

    @mattdowle
    mattdowle committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    e573daa View commit details
    Browse the repository at this point in the history

  4. cover error if na.rm is not FALSE, TRUE or 'row' when optimized and n… 

    …ot optimized by group, and outside query
    @mattdowle
    mattdowle committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    4ca0838 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. include all-NA list group and some NULL

    @mattdowle
    mattdowle committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    b3b102b View commit details
    Browse the repository at this point in the history

  2. final todo: NULL->NA in list columns when na.rm='row'

    @mattdowle
    mattdowle committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    a37e734 View commit details
    Browse the repository at this point in the history

  3. coverage

    @mattdowle
    mattdowle committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    3efdcb4 View commit details
    Browse the repository at this point in the history

  4. add na.rm=row to last.Rd

    @mattdowle
    mattdowle committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    498d168 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. address Michael's feedback

    @mattdowle
    mattdowle committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    a9e14b9 View commit details
    Browse the repository at this point in the history

  2. add details to ?last explaining why not na.rm='col' and asking for fe… 

    …edback
    @mattdowle
    mattdowle committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    31accc5 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. fix edgy case n=0 thanks to Ben

    @mattdowle
    mattdowle committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    cb8f201 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. coverage

    @mattdowle
    mattdowle committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    29c6825 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2022

  1. return number of non-NA by group as attribute

    @mattdowle
    mattdowle committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    08d6414 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2022

  1. interim

    @mattdowle
    mattdowle committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    783d9d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. merge master

    @mattdowle
    mattdowle committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    2aed4cc View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Merge branch 'master' into last_narm

    @mattdowle
    mattdowle committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    c28786a View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Added gforce_dynamic attrib returned by gfirstlast and gshift to gfor… 

    …ce at C level which now reps grpcols instead of R level
    @mattdowle
    mattdowle committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    94eb6ed View commit details
    Browse the repository at this point in the history

  2. merge master

    @mattdowle
    mattdowle committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    394556a View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. repeat tests with optimization off and on

    @mattdowle
    mattdowle committed Aug 4, 2022
    1 Configuration menu
    Copy the full SHA
    4964908 View commit details
    Browse the repository at this point in the history

  2. top align

    @mattdowle
    mattdowle committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    c9f5507 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. first/last return 'true vectors' so dogroups.c knows not to recycle l… 

    …ength-1 and pad with NA
    @mattdowle
    mattdowle committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    b0e6ba1 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. comments only

    @mattdowle
    mattdowle committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    9256ad7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. catch first/last n>1 := by group with helpful error

    @mattdowle
    mattdowle committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    beded95 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. wip shift multiple n return data.table rather than list

    @mattdowle
    mattdowle committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    966f00b View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Merge branch 'master' into last_narm

    @MichaelChirico
    MichaelChirico committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    324ce38 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. one more resolution

    @MichaelChirico
    MichaelChirico committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    0fb58b5 View commit details
    Browse the repository at this point in the history

  2. more resolution

    @MichaelChirico
    MichaelChirico committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    48281d5 View commit details
    Browse the repository at this point in the history