Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated error message in rbindlist to display the class attributes of mismatching columns #4822

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Updated error message in rbindlist to display the class attributes of mismatching columns #4822

wants to merge 8 commits into from

Commits on Nov 26, 2020

  1. Updated error message in rbindlist to display the class attributes of… 

    … mismatching columns

- added 2 tests
- added joinCharVec utility function to join each element of a character vector into a single C string
- updated translations for the new error message
- added *.sublime-project and *.sublime-workspace to .gitignore
    @logworthy
    logworthy committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    66f84f3 View commit details
    Browse the repository at this point in the history

  2. fixed call to strlen

    @logworthy
    logworthy committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    dfc8b80 View commit details
    Browse the repository at this point in the history

  3. incorporating PR feedback 

    - renamed joinCharVec to concatCharVec
- fixed spacing
- added # nocov
- fixed calls to 'free'
- moved variable declarations to point of use
    @logworthy
    logworthy committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    d37a3cf View commit details
    Browse the repository at this point in the history

  4. more targeted used of # nocov within utils.c

    @logworthy
    logworthy committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    c99f240 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. updated concatCharVec to return a CHARSXP

    @logworthy
    logworthy committed Nov 29, 2020
    1 Configuration menu
    Copy the full SHA
    4e4f62f View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. merged upstream changes

    @logworthy
    logworthy committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    cce8bdf View commit details
    Browse the repository at this point in the history

  2. reverted formatting issue

    @logworthy
    logworthy committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    abe9126 View commit details
    Browse the repository at this point in the history

  3. re-added concatCharVec function

    @logworthy
    logworthy committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    f8150fe View commit details
    Browse the repository at this point in the history